DEPS: bump sqlalchemy min support version to 1.4.0 #43191
Conversation
There was a problem hiding this comment.
This is quite a big jump forward in terms of time.
SQLAlchemy 1.3.11 = November 19
SQLAlchemy 1.4.0 = March 21
I know in the past we've wanted to move abit more slowly. So cc @jreback for a decision on this.
|
no this is fine |
There was a problem hiding this comment.
Think you will also need to update: https://github.com/pandas-dev/pandas/blob/master/pandas/compat/_optional.py#L29
and https://github.com/pandas-dev/pandas/blob/master/ci/deps/actions-38-locale_slow.yaml#L26
otherwise looks good
|
hah I didn't realize this was just a dep bump, ok. |
|
@fangchenli if we wanted to have pre 1.4 compat (as well); how hard would this be? |
pre 1.4 sqlalchemy freezes the CI in #42976. We could delay the refactoring of SQL tests to keep the pre 1.4 compact. |
|
I think we might even have sqlalchemy 1.4 compat problems see #40682. This might not be safe to do for 1.4. |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
@lithomas1 can you clarify are you saying this isn't safe to do for pandas 1.4 or isnt safe to support sqlalchemy 1.4? |
|
I meant bumping the min version for pandas 1.4.0. Sorry for the confusion |
|
@fangchenli status of this? |
ready |
|
can you add a whatsnew note about this change (assume we are dropping < 1.4)? (fine by me) |
It's already included in the 1.4 whatsnew doc. |
|
thanks @fangchenli |
precursor of #42976